Add Hypemachine support#208
Conversation
ColinDuquesnoy
left a comment
ColinDuquesnoy
left a comment
There was a problem hiding this comment.
It looks good. There are a few indentation issues and some improvements could be done.
Do you think you can tweak logo.svg to match the style of all the other services logo?
| // not supported | ||
| } | ||
|
|
||
| function readTime(elementClassName) { |
There was a problem hiding this comment.
MellowPlayer provide you with an utility function toSeconds that do exatcly what readTime does (see http://mellowplayer.readthedocs.io/en/latest/developers/plugins.html#utility-functions). Please use it instead.
There was a problem hiding this comment.
Now that I've had a look at your commit it looks good.
plugins/hypemachine/integration.js
Outdated
| return hasClass(document.getElementById("playerFav"), "fav-on"); | ||
| } | ||
|
|
||
| function hasNext() { |
There was a problem hiding this comment.
This function is useless, better set the property to true directly. Unless you planned to implement detection of next/previous songs?
| return true; | ||
| } | ||
|
|
||
| function hasClass(elem, className) { |
There was a problem hiding this comment.
Indentation in this function looks broken
|
I made a new icon but i'm having issues with the svg. It renders perfectly fine in all the apps I opened it into except in Mellowplayer, it looks stretched... It should look like this : |
|
Thank you for looking in the logo. I think you have this issue because your canvas is not square. I'd suggest you start from the empty template |
|
you were right, I think it's ok now |
|
Thank you. I'll have a look ASAP |
|
The icon looks good! |
2 participants
add Hypemachine plugin.
Hopefully this one will work seamlessly :)