This repository was archived by the owner on May 3, 2019. It is now read-only.
Feature pocketcasts plugin#117
Merged
ColinDuquesnoy merged 2 commits intoColinDuquesnoy:developfrom Sep 17, 2017
lkstz:feature-pocketcasts-plugin
Merged
Feature pocketcasts plugin#117ColinDuquesnoy merged 2 commits intoColinDuquesnoy:developfrom lkstz:feature-pocketcasts-plugin
ColinDuquesnoy merged 2 commits intoColinDuquesnoy:developfrom
lkstz:feature-pocketcasts-plugin
Conversation
Owner
|
Thank you! According to issue #112, this service require proprietary codecs. Can you confirm this? I'll change the plugin metadata accordingly. |
ColinDuquesnoy
added a commit
that referenced
this pull request
Sep 17, 2017
Improvement useful for the pocketcast plugin, see #117
Contributor
Author
|
Yes, Pocket Casts is streaming MP3. Since I'm on Arch Linux, I forgot to set this in the metadata. |
Owner
|
@kolletzki Thank you for confirming.
Don't worry, I already changed it and it's my fault if the wizard did not ask you the question about proprietary codecs. It will be different in next release. |
Contributor
Author
|
Thanks, this looks great. I’ll have a technical look at the new web player in a few days. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Pocket Casts web player, a popular podcast player.
The web player is built with AngularJS, which makes implementing the required functions very easy.
I modified the original Pocket Casts logo SVG slightly, so that it fits into the application. All rights belong to the original authors.