Skip to content

Add dashboard notice and improve upsell notice design#202

Merged
selul merged 3 commits intodevelopfrom
design/194
Mar 16, 2022
Merged

Add dashboard notice and improve upsell notice design#202
selul merged 3 commits intodevelopfrom
design/194

Conversation

@girishpanchal30
Copy link
Copy Markdown
Contributor

Close #194

@pirate-bot
Copy link
Copy Markdown
Contributor

pirate-bot commented Feb 25, 2022

Plugin build for 572979d is ready 🛎️!

@irinelenache
Copy link
Copy Markdown

@girishpanchal30 Tested and the upsell works fine 👍

Only one thing, i can't find any Otter blocks upsell, did we stick to only recommending Neve?
cc: @selul

@selul
Copy link
Copy Markdown
Contributor

selul commented Mar 2, 2022

@irinelenache no, we should have both.

@girishpanchal30
Copy link
Copy Markdown
Contributor Author

@selul Okay, So I need to add the same notice for Otter blocks right? But I think missing otter block part in design
Can you please check here: https://www.figma.com/file/lfDtHB51hvKH0TBBIkJfZp/Menu-Icons?node-id=1%3A8

@selul
Copy link
Copy Markdown
Contributor

selul commented Mar 2, 2022

@mghenciu can you share how you imagined their placement?

@mghenciu
Copy link
Copy Markdown

mghenciu commented Mar 2, 2022

Here is how the Otter section would look.
Figma file
Preview - Otter card
Also made a copy for the thumbnails images without shadow, in Figma - if needed.

And as mentioned, at the end of this comment, we should have just one card displayed at a time. And after each week or 2 weeks, automatically reverse them, and so on.

Example:

  • 1 user installed WP Menu Icons and sees there Neve card, after 2 weeks, he would see there Otter card. Again after 2 weeks, there will be Neve again - and keep this loop going every 2 weeks.
  • 1 user installed WP Menu Icons and sees there Otter card, after 2 weeks, he would see there Neve card. Again after 2 weeks, there will be Otter card - an so on every 2 weeks.

Let me know if there are questions during the process @girishpanchal30 .
Thank you!

@selul
Copy link
Copy Markdown
Contributor

selul commented Mar 2, 2022

In this way, we can display them randomly, either Neve and Otter. Is not a problem if each time we load something different.

@girishpanchal30
Copy link
Copy Markdown
Contributor Author

girishpanchal30 commented Mar 2, 2022

Also made a copy for the thumbnails images without shadow, in Figma - if needed.

@mghenciu Can you provide me without shadow thumbnails images for otter block upsell notices?
Thanks

@mghenciu
Copy link
Copy Markdown

mghenciu commented Mar 2, 2022

Also made a copy for the thumbnails images without shadow, in Figma - if needed.

@mghenciu Can you provide me without shadow thumbnails images for otter block upsell notices? Thanks

The frames are on the right side in Figma, @girishpanchal30 .
Screenshot 2022-03-02 at 14 26 53

And I guess you'll add the shadows with CSS.
Ping me if it doesn't work or something.

@girishpanchal30
Copy link
Copy Markdown
Contributor Author

@mghenciu I have managed to set image @irinelenache Can you please retest?
Thanks

@irinelenache
Copy link
Copy Markdown

@girishpanchal30 Tested again and now everything works fine, thank you 🚀

@selul selul merged commit 3c39f84 into develop Mar 16, 2022
@pirate-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.12.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 16, 2022
@selul selul deleted the design/194 branch February 25, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants