-
Notifications
You must be signed in to change notification settings - Fork 82
Add landing pages #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landing pages #336
Conversation
|
I just tested the build on a TasteWP instance and it works perfect, nice Job @arinaturcu I only noticed that the compression of the library images is pretty harsh. Not a critical issue, but perhaps we can do something about it (lowering the compression)? Happy to help with the screenshots if you need me to, I am not sure if these are auto-generated 🤔 |
|
Thank you for testing @JohnPixle! |
|
@arinaturcu structure is fine, I just think compression is a bit weird, I see there are very rough edges in them. It looks like it is set to Nearest Neighbour (and this is preserving the rough edges). But I don't want to complicate you with this, I will be happy to send over new ones soon. |
|
@JohnPixle Okay, I'll leave them to you then. Thank you for helping with these 🚀 |
|
Hey again @arinaturcu So, I took a deeper look with the thumbnails, I think the issue with the overly sharp edges was coming from the resizing of the images, and not the actual compression. The original images appear to be big, and when resized they appear with the rough edges. I took the initiative to provide the images to you in the final dimensions as they appear in the library, 380 x 405. I hope the dimensions are correct. If not, let me know. I also safely compressed them a bit. Now all the thumbnails of the landing pages are only 174 KB, which is significantly less than before (an original image of a single landing page template used to be about 400KB). Hope it helps 👍🏻 I did this for all 3 thumbnail types, Landing pages, Maintenance and coming soon. I am attaching the Zips here. landing-pages.zip I would also like to point out two things: 1. New templates. Apart from the landing pages, in this version of the plugin, we have one new Coming Soon template. Link here.. We also have one more Maintenance template. Link here. The thumbnails are included in the zips. 2. Template names. For the Maintenance and Coming Soon templates I would advise to start using a bit more generic names (maintenance 1, maintenance 2 etc) instead of style-related names as we do now (modern , cover etc). I am suggesting this in order to keep things easy since we are going to add more of these templates in the future, and we may not be able to define a unique style name for each of them. Let me know what you think and always happy to help for anything you may need. |
|
Great, @JohnPixle! 🚀 Thank you! |
|
@arinaturcu Tested and didn't find any problem in terms of functionality 🚀 After @JohnPixle's mentions are addressed and he approves it, this can be moved to Ready to merge ✅ |
|
Hey @JohnPixle, I made the changes. |
|
@arinaturcu Thanks for the update, we are all good with the Thumbnails quality, thanks so much for taking care of it 🙂 👍🏻 I noticed two small issues though: Wizard:
Ordering of the templates
Let me know your thoughts and don't hesitate to ping me in case you need any clarifications on the above. |
|
@JohnPixle Thank you for catching these 😄 . |
|
@arinaturcu Just checked and all looks rock-solid. Thanks so much for taking care of them, looking forward to see them live. From my side it's a green light to merge! 🚀 |
# Conflicts: # wp-maintenance-mode.php
3796446 to
df5e32d
Compare
selul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |




Adds the new Landing Pages.
Landing Pagecategory is present in the category dropdownMaintenance Pagethe page will haveMaintenance \ Coming soon \ Landing Pagedepending on the category)Closed #327.