-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve upsell section design #887
Conversation
@selul Please review upsell section design and do let me know if you have any queries. Thanks |
@girishpanchal30 will leave this for @irinelenache to do, please move it to testing. |
@girishpanchal30 Tested and found a few things:
|
@irinelenache Fixed 3 points, Please retest again |
As Irinel mentioned, @girishpanchal30, we agreed to use only the 1-column upsell message: A few other things I noticed after doing a quick test with the build:
So to not waste the work you've already done with 2 columns, I would add the logic so if the Window width is bigger than 1366px, then show all 12 Visualizer Pro benefits, but in one column, and also only if width is >1366px make the column On smaller screens <1366px, we'll keep only 6 checkmarks/benefits visible, and the Column As always, let me know if I can help with something else. |
@mghenciu Sure thank you |
Hello @mghenciu, I have applied your mentioned suggestion, Please check and do let me know if you have any queries. cc @irinelenache |
Tested now and it looks good, the changes I mentioned are implemented. |
@girishpanchal30 Tested again and the mentioned issues are fixed, thank you 👍 A single problem:
Tested with Safari/Chrome on Macbook pro - Built-in Retina Display 13,3-inch (2560 × 1600) |
@irinelenache, It may be related to the fact that the laptop is 13 inch, and the Ratio is 16:10. Maybe we could adjust/increase a bit the media query @girishpanchal30 . Essentially the idea here is to show only 6 benefits on small screens (laptops, small displays) and 12 benefits/checkmarks on larger screens, like for example a 3440x1440 Ultrawide Monitor. Probably you know best what media queries are good for such a case, and how to also keep in mind the Retina screens Irinel mentioned. |
@irinelenache @mghenciu I'm looking into this issue, I'll update you here... |
@irinelenache @mghenciu I have fixed mentioned issue, Please retest and let me know if you have any issues. |
I think it looks good @girishpanchal30, from my side. |
@girishpanchal30 Tested again and everything looks fine for me too, thank you 👍 |
🎉 This PR is included in version 3.7.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Close Codeinwp/visualizer-pro#314