Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple charts loading issue #884

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Conversation

girishpanchal30
Copy link
Contributor

Close #883

@girishpanchal30 girishpanchal30 linked an issue Jan 21, 2022 that may be closed by this pull request
@pirate-bot
Copy link
Contributor

pirate-bot commented Jan 21, 2022

Plugin build for 1e71599 is ready 🛎️!

@irinelenache
Copy link

@girishpanchal30 Tested and when i first open the page in incognito, not all charts are loading (they load when i resize the window). After refreshing the page, it works as expected. https://vertis.d.pr/gUKd9y

You can check the issue here:

 Admin area URL: https://ringrhythm.tastewp.com/2022/01/21/test-charts-fix/
 Username: irinel 
 Password: Dqhr9jevUKs 

@girishpanchal30
Copy link
Contributor Author

@irinelenache You need to disable lazy load chart here ( https://tinyurl.com/yawfvw95 )
or using this filter add_filter( 'visualizer_lazy_load_chart', '__return_false' );

Thanks

@irinelenache
Copy link

@girishpanchal30 So if lazy rendering is enabled, charts aren't supposed to properly load when i first open the page in incognito mode?

@girishpanchal30
Copy link
Contributor Author

@irinelenache I'll check the first-time lazy load chart rendering issue and update you here...

@girishpanchal30
Copy link
Contributor Author

@irinelenache Please retest again, the above issue is fixed
Thanks

@irinelenache
Copy link

@girishpanchal30 Tested again and now everything works fine, thanks 👍

@cristian-ungureanu cristian-ungureanu merged commit 8452e3e into development Feb 3, 2022
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.7.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 7, 2022
@selul selul deleted the bugfix/883 branch October 12, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple charts on the same page load inconsistently
4 participants