Skip to content

Conversation

@Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jan 23, 2024

Summary

Replaced the is(':visible') check because it prevented rendering of the charts placed in containers that are hidden (like Otter Tabs Block)

Screenshot

2024-01-23_16-21-02.mp4

Testing (from linked issue)

  1. Install Tabby Responsive Tabs
  2. Copy this code and paste it on a page:
[tabby title="First Tab"]

This is the content of the first tab.

[tabby title="Second Tab"]

This is the content of the second tab.
[tabby title="Third Tab"]

This is the content of the third tab.

[tabbyending]
  1. Insert one of the Visualizer's shortcodes inside one of the tabs.
  2. Publish and check the page

Do the same for Otter:

  1. Add the Tabs block
  2. Inside one of the tabs, insert a chart's shortcode

Close #1072

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jan 23, 2024
@pirate-bot
Copy link
Contributor

Plugin build for 46c8376 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Jan 23, 2024 that may be closed by this pull request
@irinelenache
Copy link

@Soare-Robert-Daniel Tested and everything's fine here 🚀

@vytisbulkevicius vytisbulkevicius merged commit 0add303 into development Feb 6, 2024
@vytisbulkevicius vytisbulkevicius deleted the fix/charts-on-tabs branch February 6, 2024 08:03
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts not visible inside Tabs

6 participants