Skip to content

Conversation

@GrigoreMihai
Copy link
Contributor

@GrigoreMihai GrigoreMihai commented Jan 18, 2024

Fixes https://github.com/Codeinwp/visualizer-pro/issues/408.

All the buttons are replaced and the style is also change for the ones from the plugins setting to match the design from the issue.

This how they look both in the editor and the plugin page: https://vertis.d.pr/i/pmhv3Y , https://vertis.d.pr/i/8UvhPH .

The block.js file has been built using node14.

@harshitarora-in Please let me know if they look how you expected.

For testing

  1. Install the pr plugin.
  2. Check that the Buy Now text is now replaced with Upgrade Now.
  3. Check that the previous color is no longer used and only the blue color is used for the buttons.

@pirate-bot
Copy link
Contributor

pirate-bot commented Jan 18, 2024

Plugin build for 6f9de94 is ready 🛎️!

@harshitarora-in
Copy link
Contributor

harshitarora-in commented Jan 18, 2024

@GrigoreMihai Thanks for implementing all the changes. It looks good 🚀🤝

I found an issue in the URLs and have raised a separate issue for that here.

@irinelenache
Copy link

@GrigoreMihai Tested and everything's fine here 👍

@vytisbulkevicius vytisbulkevicius merged commit ac52f8b into development Feb 6, 2024
@vytisbulkevicius vytisbulkevicius deleted the fix/409 branch February 6, 2024 08:02
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants