Skip to content

Commit 5a7d760

Browse files
girishpanchal30girishpanchal30
committed
Add description and license / creator setting fields #794 
1 parent 674bae8 commit 5a7d760

File tree

4 files changed

+78
-1
lines changed

4 files changed

+78
-1
lines changed

‎classes/Visualizer/Render/Sidebar/ChartJS.php‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,20 @@ protected function _renderGeneralSettings() {
296296

297297
$this->_renderAnimationSettings();
298298

299+
self::_renderSectionStart( esc_html__( 'License & Creator', 'visualizer' ), false );
300+
self::_renderTextItem(
301+
esc_html__( 'License', 'visualizer' ),
302+
'license',
303+
$this->license,
304+
''
305+
);
306+
self::_renderTextItem(
307+
esc_html__( 'Creator', 'visualizer' ),
308+
'creator',
309+
$this->creator,
310+
''
311+
);
312+
self::_renderSectionEnd();
299313
self::_renderGroupEnd();
300314
}
301315

‎classes/Visualizer/Render/Sidebar/Type/GoogleCharts/Gauge.php‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,28 @@ protected function _renderGeneralSettings() {
7878
$this->title,
7979
esc_html__( 'Text to display in the back-end admin area.', 'visualizer' )
8080
);
81+
82+
self::_renderTextAreaItem(
83+
esc_html__( 'Chart Description', 'visualizer' ),
84+
'description',
85+
$this->description,
86+
sprintf( esc_html__( 'Description to display in the structured data schema as explained %1$shere%2$s', 'visualizer' ), '<a href="https://developers.google.com/search/docs/data-types/dataset#dataset" target="_blank">', '</a>' )
87+
);
88+
self::_renderSectionEnd();
89+
90+
self::_renderSectionStart( esc_html__( 'License & Creator', 'visualizer' ), false );
91+
self::_renderTextItem(
92+
esc_html__( 'License', 'visualizer' ),
93+
'license',
94+
$this->license,
95+
''
96+
);
97+
self::_renderTextItem(
98+
esc_html__( 'Creator', 'visualizer' ),
99+
'creator',
100+
$this->creator,
101+
''
102+
);
81103
self::_renderSectionEnd();
82104

83105
self::_renderGroupEnd();

‎classes/Visualizer/Render/Sidebar/Type/GoogleCharts/Geo.php‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,27 @@ protected function _renderGeneralSettings() {
6464
$this->title,
6565
esc_html__( 'Text to display in the back-end admin area.', 'visualizer' )
6666
);
67+
self::_renderTextAreaItem(
68+
esc_html__( 'Chart Description', 'visualizer' ),
69+
'description',
70+
$this->description,
71+
sprintf( esc_html__( 'Description to display in the structured data schema as explained %1$shere%2$s', 'visualizer' ), '<a href="https://developers.google.com/search/docs/data-types/dataset#dataset" target="_blank">', '</a>' )
72+
);
73+
self::_renderSectionEnd();
74+
75+
self::_renderSectionStart( esc_html__( 'License & Creator', 'visualizer' ), false );
76+
self::_renderTextItem(
77+
esc_html__( 'License', 'visualizer' ),
78+
'license',
79+
$this->license,
80+
''
81+
);
82+
self::_renderTextItem(
83+
esc_html__( 'Creator', 'visualizer' ),
84+
'creator',
85+
$this->creator,
86+
''
87+
);
6788
self::_renderSectionEnd();
6889
self::_renderGroupEnd();
6990
}

‎classes/Visualizer/Render/Sidebar/Type/GoogleCharts/Tabular.php‎

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,28 @@ protected function _renderGeneralSettings() {
7373
$this->title,
7474
esc_html__( 'Text to display in the back-end admin area.', 'visualizer' )
7575
);
76+
self::_renderTextAreaItem(
77+
esc_html__( 'Chart Description', 'visualizer' ),
78+
'description',
79+
$this->description,
80+
sprintf( esc_html__( 'Description to display in the structured data schema as explained %1$shere%2$s', 'visualizer' ), '<a href="https://developers.google.com/search/docs/data-types/dataset#dataset" target="_blank">', '</a>' )
81+
);
7682
self::_renderSectionEnd();
77-
self::_renderGroupEnd();
83+
84+
self::_renderSectionStart( esc_html__( 'License & Creator', 'visualizer' ), false );
85+
self::_renderTextItem(
86+
esc_html__( 'License', 'visualizer' ),
87+
'license',
88+
$this->license,
89+
''
90+
);
91+
self::_renderTextItem(
92+
esc_html__( 'Creator', 'visualizer' ),
93+
'creator',
94+
$this->creator,
95+
''
96+
);
97+
self::_renderGroupEnd();
7898
}
7999

80100
/**

0 commit comments

Comments
 (0)