Skip to content

Conversation

@Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Mar 7, 2024

Closes #917

Summary

Instant sharing will now run only on posts with published as status. future has been removed from the allowed list.

Testing

  1. Install RoP with a social account.
  2. Activate instant sharing.
  3. Create a new post and schedule it.
  4. When pressing Schedule that post will NOT be shared to the social account.
  5. Create a new post, add some content then publish it directly. This post should be posted on the social.

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Mar 7, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review March 7, 2024 12:11
@github-actions
Copy link

github-actions bot commented Mar 7, 2024

Plugin build for 65c72d4 is ready 🛎️!

@irinelenache
Copy link

@Soare-Robert-Daniel Tested and the issue is fixed now 👍

Regarding the scheduled posts, i didn't manage to share one. I unchecked the instant share in the post editor (https://vertis.d.pr/i/peBZUM), scheduled the post and nothing happened after the post was published. Here are the ROP settings: https://vertis.d.pr/i/FBiIz2

@Soare-Robert-Daniel
Copy link
Contributor Author

Regarding the scheduled posts, i didn't manage to share one. I unchecked the instant share in the post editor (https://vertis.d.pr/i/peBZUM), scheduled the post and nothing happened after the post was published. Here are the ROP settings: https://vertis.d.pr/i/FBiIz2

@irinelenache, I could not replicate the problem. Can you share the instance?

@vytisbulkevicius
Copy link
Contributor

Hey @irinelenache, can you check here when you have time if that issue still exists? Thanks!

@Soare-Robert-Daniel
Copy link
Contributor Author

@vytisbulkevicius, I think we can merge this.

Having the schedules posted instantly seems to create more trouble for users since it might break their planned schedule than the fact that it might have a low chance of not being shared (they can always do it manually at the desired time)

@preda-bogdan preda-bogdan merged commit ec84a19 into development Apr 23, 2024
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 9.0.27 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Due to instant sharing active, scheduled posts are shared instantly inaccessible

6 participants