Skip to content

Conversation

@Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Feb 2, 2024

Problem Description

  1. On the page, you have meta-box where you can select which Social Media service you want to share the post.
  2. Once the post is saved, the options are stored inside a post meta named rop_publish_now_accounts and the data looks like this: a:1:{s:60:"twitter_aToxMzEwNTQ2NjkzMDU4OTczNjk2Ow==_1310546693058973700";s:0:"";}

The issue is that the post meta is empty by default, thus the conditions added in this PR #893 do not account for that and made the status of the check false by default.

But the users want them to be true by default.

Solution

Added true as the default value when the options are absent.

Also changed some variables named to match their purpose.

Testing

  • Have 2-3 accounts and activate instant sharing
  • Create a new post, you should see the the accounts as being checked by default.
  • Uncheck one of the accounts, publish then reload.
  • Check if the checkbox has kept it previous state.

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Feb 2, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review February 2, 2024 15:50
@github-actions
Copy link

github-actions bot commented Feb 2, 2024

Plugin build for 13c31c0 is ready 🛎️!

@irinelenache
Copy link

@Soare-Robert-Daniel Tested and the issue is fixed, but if I enable the Choose accounts manually option, the social medias will still be selected when creating a new post, as you can see in this video https://vertis.d.pr/v/VWc6VK

@Soare-Robert-Daniel
Copy link
Contributor Author

Thanks, @irinelenache, for the feedback. If the Choose accounts manually is checked, the social account will not be checked. Now, it should be closer to the original behavior.

@irinelenache
Copy link

@Soare-Robert-Daniel I checked with the latest build and now i'm not able to share any post using the Instant share feature (also nothing is added in the Sharing logs). I checked the cron sharing and that is working fine.

You can check on this instance:

 Admin area URL: https://hestia-date.s3-tastewp.com/wp-admin 
 Username: irinel 
 Password: X3jcpkpJ6zE 

@irinelenache
Copy link

@Soare-Robert-Daniel Tested and everything's fine now, thank you ✔️

@vytisbulkevicius vytisbulkevicius merged commit 61bad72 into development Feb 12, 2024
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 9.0.24 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Social media accounts are not selected with Instant sharing activated

6 participants