-
Notifications
You must be signed in to change notification settings - Fork 16
[Publish Now] Use account active state as default value for toggle check #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Publish Now] Use account active state as default value for toggle check #908
Conversation
|
@Soare-Robert-Daniel Tested and the issue is fixed, but if I enable the Choose accounts manually option, the social medias will still be selected when creating a new post, as you can see in this video https://vertis.d.pr/v/VWc6VK |
|
Thanks, @irinelenache, for the feedback. If the |
|
@Soare-Robert-Daniel I checked with the latest build and now i'm not able to share any post using the Instant share feature (also nothing is added in the Sharing logs). I checked the cron sharing and that is working fine. You can check on this instance: |
|
@Soare-Robert-Daniel Tested and everything's fine now, thank you ✔️ |
|
🎉 This PR is included in version 9.0.24 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Problem Description
rop_publish_now_accountsand the data looks like this:a:1:{s:60:"twitter_aToxMzEwNTQ2NjkzMDU4OTczNjk2Ow==_1310546693058973700";s:0:"";}The issue is that the post meta is empty by default, thus the conditions added in this PR #893 do not account for that and made the status of the check false by default.
But the users want them to be true by default.
Solution
Added
trueas the default value when the options are absent.Also changed some variables named to match their purpose.
Testing