Skip to content

Conversation

@UVLabs
Copy link
Contributor

@UVLabs UVLabs commented Apr 4, 2022

Fixed PHP 8 warning on orbit fox dashboard

Closes #735

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Plugin build for ae23ea5 is ready 🛎️!

@UVLabs
Copy link
Contributor Author

UVLabs commented Apr 4, 2022

@cristian-ungureanu To fix the PHPLint error do you think we should update the minimum version of PHP required for orbit fox to 7.0 to make use of this operator? Or just implement a different kind of randomiser function.

I checked the stats and this is what it looks like for PHP 5.6:

image

https://wordpress.org/about/stats/

@cristian-ungureanu
Copy link
Contributor

@UVLabs we shouldn't update the PHP version just because of a sorting function. Maybe we can use https://www.php.net/manual/en/function.shuffle.php instead.

@UVLabs
Copy link
Contributor Author

UVLabs commented Apr 13, 2022

@UVLabs we shouldn't update the PHP version just because of a sorting function. Maybe we can use https://www.php.net/manual/en/function.shuffle.php instead.

@cristian-ungureanu Made the change here

@irinelenache
Copy link

@UVLabs Tested and the fix works fine, will move it to Ready to merge 🚀

@cristian-ungureanu cristian-ungureanu merged commit de9151b into development Apr 18, 2022
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.10.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 27, 2022
@selul selul deleted the fix/php-8-uksort branch September 9, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants