Skip to content

Conversation

@cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Jul 19, 2021

Here's what I did here:

  1. The module does not appear if Otter is active or if the current user is new.
  2. If the module appears:

Closes #702

cristian-ungureanu and others added 7 commits May 31, 2021 17:05
- [Fix] PHP 8 errors
- [Fix] Elementor deprecated functions
##### [Version 2.10.5](v2.10.4...v2.10.5) (2021-05-31)

- [Fix] PHP 8 errors
- [Fix] Elementor deprecated functions
- [Fix] Replace Elementor deprecated functions
##### [Version 2.10.6](v2.10.5...v2.10.6) (2021-05-31)

- [Fix] Replace Elementor deprecated functions
@github-actions
Copy link

github-actions bot commented Jul 19, 2021

Plugin build for b70c4f4 is ready 🛎️!

@cristian-ungureanu
Copy link
Contributor Author

@irinelenache here's how you should test this:

  1. Create two instances on TasteWp.
  2. On the first instance get OBFX from wp.org, activate it, and make sure the Gutenberg module is active. Wait 2 minutes and then update OBFX with this version. You should:
  1. On the second instance, install directly this version of OBFX. In this case, you will be seen as a new user and the module should not appear at all.

@irinelenache
Copy link

@cristian-ungureanu I tried testing by creating an instance with obfx from wp.org, adding some blocks to a post and then updating with this version. The otter module wasn't present anymore in obfx settings and i didn't get any notice. When i checked the post that had the blocks added, they weren't visible anymore.
Can be checked on this instance:

 Admin area URL: https://dustyboat.tastewp.com/wp-admin 
 Username: irinel 
 Password: 0D-obIrbd_U 

@cristian-ungureanu
Copy link
Contributor Author

Thanks for testing @irinelenache. The problem should be fixed now.

@irinelenache
Copy link

@cristian-ungureanu tested again and now it works fine, didn't find any problem 👍

@cristian-ungureanu cristian-ungureanu merged commit 45e1c42 into development Aug 2, 2021
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.10.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 2, 2021
@selul selul deleted the feat/remove-otter branch September 9, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants