Skip to content

Conversation

@cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Oct 7, 2020

@irinelenache
Copy link

irinelenache commented Oct 8, 2020

@cristian-ungureanu

@rodica-andronache
Copy link
Contributor

rodica-andronache commented Oct 8, 2020

the same thing with the upload button not working, so it can't be tested properly for the moment
download (1)

I would also suggest we don't make the module active by default, as we did with the Header/Footer scripts which is now loaded everywhere even though is not used

@cristian-ungureanu
Copy link
Contributor Author

@irinelenache when you clone or download obfx, you first need to run "composer install" in the root of the plugin because the composer modules are not added on the repo. That's why you're getting that fatal error.

I've fixed the problem with the upload buttons and made the module not active by default.

@rodica-andronache
Copy link
Contributor

@cristian-ungureanu The upload button doesn't work well when you try to edit an already created custom font
https://www.loom.com/share/7ea727f22a1d4adbb4841fa4d94e28e2

@cristian-ungureanu
Copy link
Contributor Author

@rodica-andronache should be fine now

@rodica-andronache
Copy link
Contributor

@cristian-ungureanu
Copy link
Contributor Author

@rodica-andronache fixed it.

@rodica-andronache rodica-andronache merged commit 59787e0 into development Oct 9, 2020
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 9, 2020
@selul selul deleted the feat/custom-fonts-module branch February 25, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants