Skip to content

Conversation

@cristian-ungureanu
Copy link
Contributor

  • Better error handling when importing images
  • Change the dimension of the image from original to large so the import won't take that long

@rodica-andronache
Copy link
Contributor

rodica-andronache commented Apr 23, 2020

@cristian-ungureanu

  • the Load More Images button is not clickable while the Image was inserted in post content message is displayed ( after an image is imported )

Screenshot (9)

  • And when more images are imported one after the other and more messages Image was inserted in post content are displayed at the same time, the last image on the bottom can't be imported, as you can't see the buttons for it, on hover.

Screenshot (10)

  • for any image listed based on any keyword search, I get an error and can't import it

Screenshot (11)

@cristian-ungureanu
Copy link
Contributor Author

Thanks @rodica-andronache, It should work now.

@rodica-andronache
Copy link
Contributor

@cristian-ungureanu everything's working well 👍
I'm just not sure if that z-index is the best solution. The notice is behind other elements, and just part of it is visible, depending on the theme.

Neve
Screenshot 2020-04-24 at 17 28 56

2020
Screenshot 2020-04-24 at 17 29 27

@cristian-ungureanu
Copy link
Contributor Author

cristian-ungureanu commented Apr 27, 2020

@rodica-andronache that notification has z-index 100000, that's how it's implemented in core. I've changed what I've done and now I've put the z-index 100001 on the sidebar which shouldn't interfere with anything. It's either that or we remove the notification.

@rodica-andronache
Copy link
Contributor

is looking good 👍

@rodica-andronache rodica-andronache merged commit cf85082 into development Apr 27, 2020
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.9.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 28, 2020
@selul selul deleted the mystock-module branch February 25, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants