Skip to content
This repository was archived by the owner on Jan 4, 2022. It is now read-only.

Version 1.5.0 #256

Merged
HardeepAsrani merged 15 commits into from
Mar 30, 2020
Merged

Version 1.5.0 #256

HardeepAsrani merged 15 commits into from
Mar 30, 2020

Conversation

@HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Mar 28, 2020

No description provided.

@HardeepAsrani
Use Responsive Control in Layout Control
21112ec
@HardeepAsrani
minor changes
7356bc9
@HardeepAsrani
Remove Popover from Sizing Control
e5d0606 
Remove Popover from Sizing Control Codeinwp#242
@HardeepAsrani
Improve Responsive Control
537dc40 
This makes use the Device View uniform in the editor, instead of each
control having a local state. Also with latest Gutenberg, it uses
Editor's View from Data Module. Part of Codeinwp#245
@HardeepAsrani
Merge pull request #16 from Codeinwp/development
7ebce6e 
Development
@HardeepAsrani
fix CSS minification
bc81bc0
@HardeepAsrani
Responsive Control improvements
b024ba5 
Make sure it looks consistent for all WP releases.
@HardeepAsrani
Merge branch 'view-switcher' into development
e01f5f3
@HardeepAsrani
Merge pull request #17 from HardeepAsrani/development
63c4457 
Rebase
@HardeepAsrani
[WIP] improved responsiveness
c000a18
@HardeepAsrani
Improve responsiveness
cc9c853 
Make sure that device selection doesn't change on mobile-sized devices.
@HardeepAsrani
Merge pull request #18 from HardeepAsrani/view-switcher
b887335 
View switcher
@HardeepAsrani
Add Border to Button Group in Global Defaults
f910d0c 
As asked on Notion, add Border Color & Size/Radius in Global Defaults
for Button Group. Close Codeinwp#238
@HardeepAsrani
Fix missing prop
d727d9c
@rodica-andronache
Copy link

rodica-andronache commented Mar 30, 2020

@HardeepAsrani couldn't really spot issues here. There's just one thing which I'm not sure about.

If you enter a certain padding on Desktop for example and move to Tablet or Mobile, the padding controls are empty, which means they will inherit the values from Desktop ( so they are not 0 ).
But if I want to enter 0 for padding, that does not appear to save in the option, even though it applies on the frontend. https://www.loom.com/share/56d7aed881214d7fb9bd981e82b086b9

Besides that, even though I think I've mentioned before, ( sorry ), I find the process of choosing a custom color for any of the color controls very weird in the Globals options. After opening the color picker, unless I click on Custom Color again, the color picker does not close, which every time makes me think that it's broken, as it doesn't look to select any color anyway.

@HardeepAsrani
Copy link
Member Author

HardeepAsrani commented Mar 30, 2020

@rodica-andronache Thanks. Fixed that. And yes, the Color thing is an issue which makes me frustrated too. This release was done in a hurry to fix a bug. Promise to fix it in the upcoming one. :D

Thanks for the review!

@HardeepAsrani HardeepAsrani marked this pull request as ready for review March 30, 2020 21:34
@HardeepAsrani HardeepAsrani merged commit 3e355d7 into Codeinwp:development Mar 30, 2020
@pirate-bot
Copy link
Contributor

pirate-bot commented Mar 30, 2020

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HardeepAsrani @rodica-andronache @pirate-bot