Skip to content

Declare nullable parameter types explicitly for PHP 8.4 compatibility#197

Merged
TavoNiievez merged 1 commit intoCodeception:mainfrom
W0rma:explicit-nullable-parameter-types
Jul 26, 2024
Merged

Declare nullable parameter types explicitly for PHP 8.4 compatibility#197
TavoNiievez merged 1 commit intoCodeception:mainfrom
W0rma:explicit-nullable-parameter-types

Conversation

@W0rma
Copy link
Copy Markdown
Contributor

@W0rma W0rma commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

@burned42 burned42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TavoNiievez TavoNiievez merged commit 9b77251 into Codeception:main Jul 26, 2024
@W0rma W0rma deleted the explicit-nullable-parameter-types branch July 29, 2024 04:24
@TavoNiievez TavoNiievez added this to the 3.5.0 milestone Aug 18, 2024
@W0rma W0rma mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants