Remove dependency on laminas/laminas-console#13
Merged
TavoNiievez merged 3 commits intoCodeception:masterfrom Jul 23, 2021
Merged
Remove dependency on laminas/laminas-console#13TavoNiievez merged 3 commits intoCodeception:masterfrom
TavoNiievez merged 3 commits intoCodeception:masterfrom
Conversation
Member
|
@javabudd php 7.3 is supported until December of this year. Can you please assign PHP 7.3 as a minimum? |
TavoNiievez
approved these changes
Jul 12, 2021
Contributor
Author
|
@TavoNiievez Support for 7.3 has been added back |
Member
Contributor
Author
|
@TavoNiievez any updates on a new tag for this? |
Member
|
@javabudd I released this as version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #12 and removes the dependency on
laminas/laminas-console. Aclass_existscheck is still happening in \Codeception\Module\Laminas line 98, which should preserve functionality for older clients.A major version is recommended for this PR, as we are dropping support for PHP < 7.3