Migrate commands to use AsCommand attribute#6850
Merged
TavoNiievez merged 1 commit intoCodeception:mainfrom May 1, 2025
Merged
Migrate commands to use AsCommand attribute#6850TavoNiievez merged 1 commit intoCodeception:mainfrom
TavoNiievez merged 1 commit intoCodeception:mainfrom
Conversation
TavoNiievez
force-pushed
the
as_command
branch
3 times, most recently
from
74bd4a8 to
fbe5d97
Compare
W0rma
approved these changes
May 1, 2025
Comment on lines
+25
to
29
| #[AsCommand( | ||
| name: 'generate:page', | ||
| description: 'Generates empty PageObject class' | ||
| )] | ||
| class GeneratePageObject extends Command |
Contributor
There was a problem hiding this comment.
I'm not familiar with the autogenerated console name which was created before but wasn't it generate:pageobject instead of generate:page?
generate:pageobject is shown if I run vendor/bin/codecept list in my local app.
Member
Author
There was a problem hiding this comment.
don't worry, you're right.
I fixed the following names: generate:environment, generate:groupobject, generate:pageobject
self-update is not listed, but I never used that and I don't even know if it is working.
Member
Author
There was a problem hiding this comment.
The interesting thing about this is that the tests did not complain despite the change, suggesting that we are not testing this as we should ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.