Skip to content

Declare nullable parameter types explicitly for PHP 8.4 compatibility#6774

Merged
TavoNiievez merged 1 commit intoCodeception:5.1from
W0rma:explicit-nullable-parameter-type
Jul 28, 2024
Merged

Declare nullable parameter types explicitly for PHP 8.4 compatibility#6774
TavoNiievez merged 1 commit intoCodeception:5.1from
W0rma:explicit-nullable-parameter-type

Conversation

@W0rma
Copy link
Copy Markdown
Contributor

@W0rma W0rma commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

@burned42 burned42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@TavoNiievez
Copy link
Copy Markdown
Member

@W0rma Do you think you can raise a PR for the 5.2 branch as well?

@W0rma
Copy link
Copy Markdown
Contributor Author

W0rma commented Jul 27, 2024

@W0rma Do you think you can raise a PR for the 5.2 branch as well?

@TavoNiievez Sure - see #6775

@TavoNiievez TavoNiievez merged commit 73fd3c9 into Codeception:5.1 Jul 28, 2024
@W0rma W0rma deleted the explicit-nullable-parameter-type branch March 11, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants