Update the codebase to PHP 8.1#6747
Merged
TavoNiievez merged 5 commits intoCodeception:5.2from May 29, 2024
TavoNiievez:5.1
Merged
Update the codebase to PHP 8.1#6747TavoNiievez merged 5 commits intoCodeception:5.2from TavoNiievez:5.1
TavoNiievez merged 5 commits intoCodeception:5.2from
TavoNiievez:5.1
Conversation
TavoNiievez
commented
Mar 21, 2024
Naktibalda
requested changes
Apr 4, 2024
Member
Naktibalda
left a comment
Naktibalda
left a comment
There was a problem hiding this comment.
What version is it going to be? 5.2.0? 6.0.0?
I think that 5.1 branch should stay compatible with PHP 8.0 in cases there is some critical bug that must be fixed.
Member
Author
|
@Naktibalda In my PR for the command folder I also had to move the minimum version of Symfony to 5.4. I don't plan to add any breaking changes, I'm just going to remove inconsistencies in the code where I find them or rewrite small pieces of code for some simpler or more modern alternative from a Symfony or PHP version point of view. |
Naktibalda
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cherry-picked the commit from my other PR (#6746) to demonstrate that the tests run correctly.
I will delete it as soon as it is merged.
This PR should be merged with the Squash and merge strategy.