fix Lumen file upload via REST module#5082
Merged
DavertMik merged 2 commits intoCodeception:2.4from Jul 31, 2018
Merged
Conversation
Naktibalda
requested changes
Jul 27, 2018
Member
Naktibalda
left a comment
Naktibalda
left a comment
There was a problem hiding this comment.
Please add missing use statement and test it locally with your project.
| if (is_array($value)) { | ||
| $filtered[$key] = $this->convertToTestFiles($value); | ||
| } else { | ||
| $filtered[$key] = UploadedFile::createFromBase($value, true); |
Member
There was a problem hiding this comment.
It looks like copy-paste from Laravel5 module, but you missed use Illuminate\Http\UploadedFile; line at the top.
https://github.com/Codeception/Codeception/blob/2.4.4/src/Codeception/Lib/Connector/Laravel5.php#L10
Contributor
Author
|
tested with my project and it's working |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #5081
(there's no Lumen tests)