Skip to content

Fixed undefined argv warnings, added check for register_argc_argv#4650

Merged
DavertMik merged 2 commits intoCodeception:2.3from
Naktibalda:argc-argv
Nov 28, 2017
Merged

Fixed undefined argv warnings, added check for register_argc_argv#4650
DavertMik merged 2 commits intoCodeception:2.3from
Naktibalda:argc-argv

Conversation

@Naktibalda
Copy link
Copy Markdown
Member

@Naktibalda Naktibalda commented Nov 27, 2017

Fixes #4595

@Naktibalda
Copy link
Copy Markdown
Member Author

Naktibalda commented Nov 28, 2017

My change broke codeception CLI tests on wercker:

Fatal error: Uncaught exception 'Codeception\Exception\ConfigurationException' with message 'register_argc_argv must be set to On for running Codeception' in /pipeline/source/src/Codeception/Application.php:104
Stack trace:
#0 /pipeline/source/codecept(42): Codeception\Application->run()
#1 {main}

Wercker runs tests using HHVM, so this is HHVM specific issue.

@DavertMik
Copy link
Copy Markdown
Member

DavertMik commented Nov 28, 2017

Thanks!

@DavertMik DavertMik merged commit 3e4d67f into Codeception:2.3 Nov 28, 2017
@Naktibalda Naktibalda deleted the argc-argv branch November 28, 2017 23:07
@W0rma W0rma mentioned this pull request Jan 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavertMik DavertMik DavertMik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Naktibalda @DavertMik