Skip to content

Evaluate ContentLength as int #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Code-Hex merged 1 commit into from
Apr 28, 2017
Merged

Evaluate ContentLength as int #21

Code-Hex merged 1 commit into from
Apr 28, 2017

Conversation

@lon9
Copy link
Contributor

@lon9 lon9 commented Apr 27, 2017

If Content-Length is not shown on the header, res.ContentLength would be -1 (https://golang.org/pkg/net/http/#Response)
If we cast it to uint, it become a max value of uint, so we have to evaluate it as int64

@coveralls
Copy link

coveralls commented Apr 27, 2017

Coverage Status

Coverage decreased (-0.4%) to 75.092% when pulling 542320b on Rompei:fix-content-length-evaluation into 7bace10 on Code-Hex:master.

@Code-Hex
Copy link
Owner

Code-Hex commented Apr 28, 2017

@Rompei Thanks!! Nice PR.

@Code-Hex Code-Hex merged commit 9294f74 into Code-Hex:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lon9 @coveralls @Code-Hex