Improve ProtocolZero behavior on MP game load#45
Merged
Metadorius merged 3 commits intomainfrom Jun 29, 2025
Merged
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Belonit
force-pushed
the
fix-ProtocolZero-NextSendFrame-for-MP-saveload
branch
from
26c81ab to
8380268
Compare
Metadorius
changed the title
Metadorius
reviewed
Jun 28, 2025
src/Spawner/ProtocolZero.h
Outdated
Comment on lines
36
to
42
| static void Init() | ||
| { | ||
| Enable = false; | ||
| WorstMaxAhead = 24; | ||
| NextSendFrame = -1; | ||
| MaxLatencyLevel = 0xff; | ||
| } |
Member
There was a problem hiding this comment.
Why not assign values right to the static vars?
Contributor
There was a problem hiding this comment.
Also 0xff should be UCHAR_MAX or the std::limits whatever version of that
Member
Author
There was a problem hiding this comment.
Ok, I worked on the comment, look again
Metadorius
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.