fix: bottomsheet-1.3.1.aar incorrectly includes aapt/AndroidManifest.xml#23
fix: bottomsheet-1.3.1.aar incorrectly includes aapt/AndroidManifest.xml#23Doko-Demo-Doa merged 1 commit intoClip-sub:masterfrom mikehardy:androidx-dependency-fix
Conversation
I removed it, re-packed it, put it in android/libs and referenced it from libs The dependency is effectively dead / unsupported anyway, so should not be a maintenance burden
|
I should mention, if you don't trust me enough to take my binary aar file (and who am I anyway?? don't trust me!) the alteration to the aar was: mkdir temp && cd temp
jar -xvf ../bottomsheet-1.3.1.aar && rm ../bottomsheet-1.3.1.aar
\rm -fr aapt # This is the fix, aapt/AndroidManifest.xml is the problem
jar -cvf ../bottomsheet-1.3.1.aar *Then just throw that in android/libs and reference it like so in the gradle. |
|
@Doko-Demo-Doa I think this will fix the dependency for your library so you're library users are ready for AndroidX if they want |
|
Sure, let me check and do the merging. |
|
Thank you. Your implementation works well. v2.0.1 pushed with crashing issue fixed too. |
|
It seems in version 2.2.0 this error occurs again, or something very similar. react-native:0.63.4 I just ran UPD: I downgraded back to 2.0.1 but the problem persists. It seems to be a matter of updating react-native. P.s. Perhaps someone who is better versed in native code than me will look at this and say that I'm wrong. I'll be glad if this is so, but so far I realized that things are bad here. P.s.s. Apparently the problem is still different from the original one, and I should have opened new issues, but I beg your pardon, I don't have much time for this now. |
|
I see. I think it's better to fork another lib instead of continuing to use current one. Any suggestions? |
|
2.5.2 released and it should be what you are looking for. |

I removed it, re-packed it, put it in android/libs and referenced it from libs
The dependency is effectively dead / unsupported anyway, so should not be
a maintenance burden
Fixes #22
Demonstrated working at https://github.com/mikehardy/rn-androidx-demo / https://github.com/mikehardy/rn-androidx-demo/blob/master/make-demo.sh#L34