Add LLVM/clang 16 support and switch to it#8
Add LLVM/clang 16 support and switch to it#8alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Conversation
Actually 17 should be enough
|
Is it possible to update upstream as well? We have issue related to the old version of codebrowser ClickHouse/ClickHouse#46299 |
|
@Felixoid, the issue you've linked is introduced by me - I was so busy disabling the animation, round corners, shadow, and transparency, that overlooked it. |
|
It's not clear to me if something needs to be done, or if the issue will be solved automatically. BTW, @azat, it breaks the master. Are you sure that it actually requires minimum 16th version? https://github.com/ClickHouse/woboq_codebrowser/pull/8/files#diff-6f85a0c9e464c182bf97c7013f1eddc1738de405dc342175a15e3514ea9ef258R4 Let's revert it and make it working on both versions? |
It does not, let's simply remove that strict version requirement, I don't know why it is there - #9 |
This patch is a backport of the the initial patch that is targeted upstream - KDAB#110 But maybe you are talking about remove that custom ClickHouse patches, then it definitely worth it, although I don't know what was the purpose, apparently, like @alexey-milovidov wrote, some style fixes. |
|
@azat Yes, we have strict no to animations, round corners, and shadows for our website assets. |
Upstream PR: KDAB#110
This is a series of PRs to switch ClickHouse to LLVM 16