Skip to content

Add LLVM/clang 16 support and switch to it#8

Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
azat-archive:ch/llvm-16
May 9, 2023
Merged

Add LLVM/clang 16 support and switch to it#8
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
azat-archive:ch/llvm-16

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented May 8, 2023

Upstream PR: KDAB#110

This is a series of PRs to switch ClickHouse to LLVM 16

@azat azat mentioned this pull request May 8, 2023
@Felixoid
Copy link
Copy Markdown
Member

Felixoid commented May 8, 2023

Is it possible to update upstream as well?

We have issue related to the old version of codebrowser ClickHouse/ClickHouse#46299

@alexey-milovidov alexey-milovidov self-assigned this May 9, 2023
@alexey-milovidov
Copy link
Copy Markdown
Member

@Felixoid, the issue you've linked is introduced by me - I was so busy disabling the animation, round corners, shadow, and transparency, that overlooked it.

@alexey-milovidov alexey-milovidov merged commit 4d0263e into ClickHouse:master May 9, 2023
@azat azat deleted the ch/llvm-16 branch May 9, 2023 08:12
@Felixoid
Copy link
Copy Markdown
Member

Felixoid commented May 9, 2023

It's not clear to me if something needs to be done, or if the issue will be solved automatically.

BTW, @azat, it breaks the master. Are you sure that it actually requires minimum 16th version? https://github.com/ClickHouse/woboq_codebrowser/pull/8/files#diff-6f85a0c9e464c182bf97c7013f1eddc1738de405dc342175a15e3514ea9ef258R4

#0 1.645 CMake Error at generator/CMakeLists.txt:4 (Find_Package):
#0 1.645   Could not find a configuration file for package "LLVM" that is compatible
#0 1.645   with requested version "16".
#0 1.645
#0 1.645   The following configuration files were considered but not accepted:
#0 1.645
#0 1.645     /usr/lib/llvm-15/cmake/LLVMConfig.cmake, version: 15.0.7
#0 1.645     /lib/llvm-15/cmake/LLVMConfig.cmake, version: 15.0.7
#0 1.645
#0 1.645
#0 1.645
#0 1.645 -- Configuring incomplete, errors occurred!

Let's revert it and make it working on both versions?

@azat
Copy link
Copy Markdown
Member Author

azat commented May 9, 2023

BTW, @azat, it breaks the master. Are you sure that it actually requires minimum 16th version? #8 (files)

It does not, let's simply remove that strict version requirement, I don't know why it is there - #9

@azat
Copy link
Copy Markdown
Member Author

azat commented May 9, 2023

Is it possible to update upstream as well?

This patch is a backport of the the initial patch that is targeted upstream - KDAB#110

But maybe you are talking about remove that custom ClickHouse patches, then it definitely worth it, although I don't know what was the purpose, apparently, like @alexey-milovidov wrote, some style fixes.

@alexey-milovidov
Copy link
Copy Markdown
Member

@azat Yes, we have strict no to animations, round corners, and shadows for our website assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants