Include sanitizer/msan_interface.h for __msan_unpoison()#5
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Sep 9, 2022
Merged
Include sanitizer/msan_interface.h for __msan_unpoison()#5alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
Clang-15 now complains [1]:
Sep 06 18:49:22 FAILED: contrib/sentry-native-cmake/CMakeFiles/_sentry.dir/__/sentry-native/src/sentry_unix_pageallocator.c.o
Sep 06 18:49:22 /usr/bin/ccache /usr/bin/clang-15 --target=x86_64-linux-gnu --sysroot=/build/cmake/linux/../../contrib/sysroot/linux-x86_64/x86_64-linux-gnu/libc -DHAS_RESERVED_IDENTIFIER -DSENTRY_BUILD_STATIC -DSENTRY_WITH_INPROC_BACKEND -DSIZEOF_LONG=8 -DSTD_EXCEPTION_HAS_STACK_TRACE=1 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -I../contrib/sentry-native/include -I../contrib/sentry-native/src -I../base/glibc-compatibility/memcpy -isystem ../contrib/libcxx/include -isystem ../contrib/libcxxabi/include -isystem ../contrib/libunwind/include -isystem ../contrib/curl/include -isystem ../contrib/curl/lib -isystem ../contrib/curl-cmake/. --gcc-toolchain=/build/cmake/linux/../../contrib/sysroot/linux-x86_64 -g -fno-omit-frame-pointer -DSANITIZER -fsanitize=memory -fsanitize-memory-use-after-dtor -fsanitize-memory-track-origins -fno-optimize-sibling-calls -fsanitize-blacklist=/build/tests/msan_suppressions.txt -fdiagnostics-color=always -Xclang -fuse-ctor-homing -gdwarf-aranges -pipe -mssse3 -msse4.1 -msse4.2 -mpclmul -mpopcnt -fasynchronous-unwind-tables -ffile-prefix-map=/build=. -falign-functions=32 -mbranches-within-32B-boundaries -fdiagnostics-absolute-paths -fexperimental-new-pass-manager -w -O2 -g -DNDEBUG -O3 -g -gdwarf-4 -fno-pie -D OS_LINUX -Werror -std=gnu11 -MD -MT contrib/sentry-native-cmake/CMakeFiles/_sentry.dir/__/sentry-native/src/sentry_unix_pageallocator.c.o -MF contrib/sentry-native-cmake/CMakeFiles/_sentry.dir/__/sentry-native/src/sentry_unix_pageallocator.c.o.d -o contrib/sentry-native-cmake/CMakeFiles/_sentry.dir/__/sentry-native/src/sentry_unix_pageallocator.c.o -c ../contrib/sentry-native/src/sentry_unix_pageallocator.c
Sep 06 18:49:22 /build/contrib/sentry-native/src/sentry_unix_pageallocator.c:65:5: error: call to undeclared function '__msan_unpoison'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
Sep 06 18:49:22 __msan_unpoison(rv, g_alloc->page_size * num_pages);
Sep 06 18:49:22 ^
[1]: https://s3.amazonaws.com/clickhouse-builds/41046/0e9265ad951d40cdce3716fb8a679360b2e0c156/package_msan/build_log.log
alexey-milovidov
approved these changes
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang-15 now complains 1:
Refs: ClickHouse/ClickHouse#41046