Conversation
serprex
force-pushed
the
fix-oob-parsing
branch
from
34c782d to
e3b4ee0
Compare
theory
approved these changes
Feb 24, 2026
Collaborator
theory
left a comment
theory
left a comment
There was a problem hiding this comment.
Can you add a test case?
Member
Author
|
@theory test case would require intermediate proxy to emit malicious string; ClickHouse won't generate a string that'd hit this code path or we include UDF that parses |
Collaborator
|
Unit testing is super hard with Postgres extensions. I've no objection, can do without a test case. |
theory
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.