Conversation
theory
added
bug
Teach the binary engine to convert ClickHouse `IPv4` and `IPv6` types to Postgres `INET`, then to convert Postgres `UUID` and `INET` values to ClickHouse binary values for inserts. Also fix a crash when attempting to insert an unsupported type with the binary engine. Teach `chfdw_datum_to_ch_literal` to convert Postgres `UUID` and `INET` values to ClickHouse literal strings. Add tests to `binary_inserts` and `http_inserts` test files that create tables using ClickHouse `UUID`, `IPv4`, and `IPv6` columns, import them as Postgres `UUID` and `INET` columns, insert values, and fetch them from ClickHouse. While at it, add a comment to `clickhouseAcquireSampleRowsFunc()` suggesting that it be implemented using the ClickHouse `SELECT SAMPLE` feature.
theory
force-pushed
the
uuid-inet-insert
branch
from
c209705 to
a19cb7b
Compare
serprex
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teach the binary engine to convert ClickHouse
IPv4andIPv6types to PostgresINET, then to convert PostgresUUIDandINETvalues to ClickHouse binary values for inserts. Also fix a crash when attempting to insert an unsupported type with the binary engine.Teach
chfdw_datum_to_ch_literalto convert PostgresUUIDandINETvalues to ClickHouse literal strings.Add tests to
binary_insertsandhttp_insertstest files that create tables using ClickHouseUUID,IPv4, andIPv6columns, import them as PostgresUUIDandINETcolumns, insert values, and fetch them from ClickHouse.While at it, add a comment to
clickhouseAcquireSampleRowsFunc()suggesting that it be implemented using the ClickHouseSELECT SAMPLEfeature.Resolves #127.