Skip to content

Fix BYTE statistics on platforms with unsigned 'char'#13

Merged
al13n321 merged 1 commit intomainfrom
sine
May 31, 2024
Merged

Fix BYTE statistics on platforms with unsigned 'char'#13
al13n321 merged 1 commit intomainfrom
sine

Conversation

@al13n321
Copy link
Copy Markdown
Member

ORC's BYTE type is signed, but the library used char type for calculating min/max values. It broke in ARM builds.

@alexey-milovidov alexey-milovidov self-assigned this May 29, 2024
@al13n321 al13n321 marked this pull request as ready for review May 31, 2024 19:13
@al13n321 al13n321 merged commit bcc025c into main May 31, 2024
@al13n321 al13n321 deleted the sine branch May 31, 2024 20:05
@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented Jun 1, 2024

(Trying to upstream this: apache#1947 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants