Emit .eh_frame (unwind info)#1
Merged
alexey-milovidov merged 1 commit intoclickhouse/v1.2.5from Aug 14, 2024
Merged
Conversation
This was referenced Aug 14, 2024
alexey-milovidov
approved these changes
Aug 14, 2024
Member
|
Thank you! I can guess and I totally understand their reasoning.
But we need to go against their principles :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed to make clickouse's stack traces work with musl.
As discussed in ClickHouse/sysroot#26 , IIUC, this goes against the wishes of musl authors - they don't want programs to generate their own stack traces, especially from signal handlers, especially on crash. I couldn't understand exactly why. It's at least in part because of security, but I don't know what exactly is insecure about it. What's the threat model? What types of attacks do they have in mind? Or is it just based on a general principle that program shouldn't have any unnecessary code, especially interpreter-like code? I don't know. Maybe we should look into it.
So this won't be upstreamable.