Merge change to 15.x branch#10
Conversation
handle mprotect error properly
|
Nice catch. The PR is good to go once #9 (comment) is clarified ... btw., I couldn't find a corresponding PR in the ClickHouse repo that updates the llvm-project submodule? |
It does not contains anything from #9, so I think it is safe to merge it now. Plus, I want to rebase on top of that changes (since I want to create a draft PR in ClickHouse that will include not only #9 but also #8)
It should be ClickHouse/ClickHouse#46600 |
(motivated by [0]) PRs [0]/[1] switched the git reference in ClickHouse's main repo to a feature branch derived from the correct branch (ClickHouse/releases/15.x). As per this PR, this is now fixed. The actual code state of llvm-project doesn't change. [0] ClickHouse/llvm-project#10 [1] ClickHouse/llvm-project#8 [2] #46600
What I meant was whether this PR has an equivalent in the main repo already. But nevermind, here it is: ClickHouse/ClickHouse#47719 |
Well, it can't be done until this MR merged. Yep, thanks! |
3 participants
Looks like #8 forgot to merge this to 15.x and simply switch the HEAD in the submodules, let's do this to make the HEAD of the
Clickhoues/release/15.xup to date (plus I have one more patch - #9)Cc: @rschu1ze
Cc: @hanfei1991