Revert "Implement async-signal-safe lock for DwarfFDECache"#37
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 15, 2025
Merged
Revert "Implement async-signal-safe lock for DwarfFDECache"#37alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
This reverts commit 7729044.
alexey-milovidov
approved these changes
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #34
The
#include <stdatomic.h>fails in clickhouse's freebsd build: https://s3.amazonaws.com/clickhouse-test-reports/PRs/76178/a251d6e77bddd4654546ca48f5d186fb233a3771//build_amd_freebsd/build_log.log because of the usual kind of C/C++ nonsense (need to define _Bool in stdbool.h in sysroot?). Since this whole code path doesn't do anything in clickhouse (because_LIBUNWIND_NO_HEAPis defined, disabling DwarfFDECache), let's just revert it.