Gate DwarfFDECache with _LIBUNWIND_NO_HEAP more carefully#35
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 13, 2025
Merged
Gate DwarfFDECache with _LIBUNWIND_NO_HEAP more carefully#35alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
alexey-milovidov
approved these changes
Feb 13, 2025
al13n321
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
Feb 13, 2025
al13n321
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid using mutex in DwarfFDECache when the cache is disabled.
We used to already have this: https://github.com/ClickHouse/libunwind/pull/1/files , but that change wasn't reapplied after an update: #17 . That re-broke signal safety: ClickHouse/ClickHouse#69904 . Then signal safety was fixed a different way, by making it ok to lock the mutex: #34 . Now this PR also avoid the unnecessary mutex locking.