Split public and internal drainStream and cover with tests#582
Draft
Split public and internal drainStream and cover with tests#582
drainStream and cover with tests#582Conversation
well, internally :)
Co-authored-by: Copilot <[email protected]>
thanks AI!
Co-authored-by: Copilot <[email protected]>
|
|
Copilot
AI
changed the title
[WIP] Split public and internal drainStream functions and cover with tests
Split public and internal Feb 26, 2026
drainStream and cover with tests
6e90efb to
b976d08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drainStreampreviously hung when the server closed the connection before emittingend, and had no coverage for terminal stream states (already errored/ended/closed) that create race conditions if encountered before listeners are attached.Changes
stream.ts: Split into two functions:drainStream(stream)— simplified public API (no context), exported from package entrypoint; adds early-exit guards forerrored,readableEnded, andclosedstates; resolves oncloseevent to handle server-side connection teardown beforeenddrainStreamInternal(ctx, stream)— internal variant used bynode_base_connection.ts; same logic plus TRACE-level logging of chunk counts, byte totals, and drain durationnode_base_connection.ts: Switched all call sites fromdrainStreamtodrainStreamInternalnode_stream.test.ts/node_stream_internal.test.ts: New unit test suites covering normal end, already-ended, already-errored, live error, thrown error, and already-closed stream states for both functionsChecklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.