Provide more context in logs for connection and request handling#567
Merged
peter-leonov-ch merged 23 commits intomainfrom Feb 25, 2026
Merged
Provide more context in logs for connection and request handling#567peter-leonov-ch merged 23 commits intomainfrom
peter-leonov-ch merged 23 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
peter-leonov-ch
force-pushed
the
better_user_experience_with_connection_hangup
branch
2 times, most recently
from
3821d7a to
345d241
Compare
peter-leonov-ch
force-pushed
the
better_user_experience_with_connection_hangup
branch
from
345d241 to
575de7d
Compare
peter-leonov-ch
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Node.js client observability around HTTP keep-alive socket/request lifecycle by adding stable per-connection/per-request identifiers to logs, and extends integration tests to cover several tricky connection failure modes (timeouts, dropped connections, malformed responses).
Changes:
- Add
connectionId,requestId, andsocketIdcontext to debug/trace/warn/error logs in the Node base connection implementation. - Expand integration tests to simulate connection drops and verify surfaced error behavior.
- Relax logger-support assertions to tolerate the new log message format; add a changelog entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
packages/client-node/src/connection/node_base_connection.ts |
Introduces connection/request/socket IDs and enriches request/socket lifecycle logs with this context. |
packages/client-node/__tests__/integration/node_socket_handling.test.ts |
Refactors timeout permutation test and adds TCP-level “dropped/malformed response” scenarios. |
packages/client-node/__tests__/integration/node_logger_support.test.ts |
Updates assertions to match the new log message format (regex-based). |
CHANGELOG.md |
Adds an entry describing enhanced request/socket lifecycle logging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/client-node/__tests__/integration/node_socket_handling.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
peter-leonov-ch
commented
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/client-node/__tests__/integration/node_socket_handling.test.ts
Outdated
Show resolved
Hide resolved
packages/client-node/__tests__/integration/node_socket_handling.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
mshustov
previously approved these changes
Feb 24, 2026
peter-leonov-ch
deleted the
better_user_experience_with_connection_hangup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting on:
command()#520Summary
Checklist
Delete items not relevant to your PR: