Skip to content

Fix JSONEachRowWithProgress types with ClickHouse 25+#443

Merged
slvrtrn merged 4 commits intomainfrom
fix-json-each-row-with-progress
Jul 21, 2025
Merged

Fix JSONEachRowWithProgress types with ClickHouse 25+#443
slvrtrn merged 4 commits intomainfrom
fix-json-each-row-with-progress

Conversation

@slvrtrn
Copy link
Copy Markdown
Contributor

@slvrtrn slvrtrn commented Jul 15, 2025 •
edited
Loading

Summary

Closes #438
Follows the test cases defined in ClickHouse/ClickHouse#74181
Adds a few scenarios as an example.

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@sonarqubecloud

This comment was marked as outdated.

Sign in to view
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 15, 2025 •
edited
Loading

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@slvrtrn slvrtrn requested a review from mshustov July 16, 2025 12:18
@mshustov
Copy link
Copy Markdown
Member

mshustov commented Jul 16, 2025

love the ration of tests to the code in this PR :D

@mshustov
Copy link
Copy Markdown
Member

mshustov commented Jul 17, 2025

qq: how does it work with 24.8 LTS version?

@slvrtrn
Copy link
Copy Markdown
Contributor Author

slvrtrn commented Jul 17, 2025 •
edited
Loading

qq: how does it work with 24.8 LTS version?

you should still be able to use isProgress type guard. Out of all SpecialEventRow, I think only exception could be constructed on that version. So having all these variants is a bit annoying, cause they did not exist back then, but all in all, it is not really a breaking change even on that version, as we provided only isProgress guard that is unchanged. Worst case scenario, the type can be simply enforced via as casts, it's just TS hints; but I don't think it will be even needed.

@slvrtrn slvrtrn merged commit fcb4fc0 into main Jul 21, 2025
27 checks passed
@slvrtrn slvrtrn deleted the fix-json-each-row-with-progress branch July 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshustov mshustov mshustov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JSONEachRowWithProgress return types no longer accurate after ClickHouse v25.1

2 participants

@slvrtrn @mshustov