[JDBC] Fixes #2592
Merged
[JDBC] Fixes #2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses several JDBC-related issues in the ClickHouse Java client, focusing on data type handling, boolean conversion, and user configuration persistence.
- Fixes boolean conversion logic to properly handle integer values (0/1) in addition to string values
- Resolves ClassCastException when retrieving network timeout default values by adding proper type casting
- Prevents user configuration from being overwritten when loading server information
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DatabaseMetaDataTest.java | Adds test coverage for nullable column metadata and nested type detection |
| DatabaseMetaDataImpl.java | Refactors type conversion logic and fixes variable naming in metadata operations |
| JdbcUtils.java | Updates boolean conversion to handle both string and numeric representations |
| SettingsTests.java | Adds validation tests for network timeout default values |
| ClientTests.java | Adds integration test for server settings functionality |
| CommonSettings.java | Fixes ClassCastException by properly casting network timeout to Long |
| Client.java | Preserves original user configuration when loading server info |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getObjectusedCloses #2586
Closes #2597
Closes #2247
Checklist
Delete items not relevant to your PR: