[JDBC-V2] Fixed spatial data returning correct type and object #2581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (1)
- jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java (1936-1936) There's a typo in the table name: 'test_geo_muti_polygon' should be 'test_geo_multi_polygon' to match the test name and data type.
💡 To request another review, post a new comment with "/windsurf-review".
Comment on lines
+123
to
+132
| public boolean equals(Object obj) { | ||
| if (this == obj) { | ||
| return true; | ||
| } | ||
| if (obj == null || getClass() != obj.getClass()) { | ||
| return false; | ||
| } | ||
| Array other = (Array) obj; | ||
| return type == other.type && java.util.Arrays.equals(array, other.array); | ||
| } |
Contributor
There was a problem hiding this comment.
You've implemented equals() but not hashCode(). According to the Java contract, when overriding equals(), you should also override hashCode() to ensure that equal objects have the same hash code. This is important if instances of this class will be used in hash-based collections like HashMap or HashSet.
Consider adding a matching hashCode() implementation like:
Suggested change
| public boolean equals(Object obj) { | |
| if (this == obj) { | |
| return true; | |
| } | |
| if (obj == null || getClass() != obj.getClass()) { | |
| return false; | |
| } | |
| Array other = (Array) obj; | |
| return type == other.type && java.util.Arrays.equals(array, other.array); | |
| } | |
| @Override | |
| public boolean equals(Object obj) { | |
| if (this == obj) { | |
| return true; | |
| } | |
| if (obj == null || getClass() != obj.getClass()) { | |
| return false; | |
| } | |
| Array other = (Array) obj; | |
| return type == other.type && java.util.Arrays.equals(array, other.array); | |
| } | |
| @Override | |
| public int hashCode() { | |
| int result = type; | |
| result = 31 * result + java.util.Arrays.hashCode(array); | |
| return result; | |
| } |
Comment on lines
1805
to
1806
| Object asObject = rs.getObject(geomColumn); | ||
| Array asArray = rs.getArray(geomColumn); |
Contributor
There was a problem hiding this comment.
The test retrieves asObject and asArray but doesn't verify their values. Consider adding assertions to validate the returned data matches the expected values, similar to how it's done in the testGeoPoint1 method.
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
Contributor
Author
|
Verified on DBeaver 25.2.1 
|
|
@chernser Thanks for this fix! As you can see by the testing suite I provided this is a crucial functionality that we need. I can't wait for the fix to land in the new version of DBeaver/Driver. Thanks again |
Contributor
Author
|
@duvenagep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ResultSet.getObjectCloses #2577
Checklist
Delete items not relevant to your PR: