[JDBC-V2, Client-V2] Fixes data type conversion to string #2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (3)
-
client-v2/src/main/java/com/clickhouse/client/api/internal/BaseCollectionConverter.java (198-200)
Include the original exception as the cause to preserve the stack trace:
} catch (IOException e) { throw new ClickHouseException(e.getMessage(), e); -
client-v2/src/main/java/com/clickhouse/client/api/internal/BaseCollectionConverter.java (207-209)
Include the original exception as the cause to preserve the stack trace:
} catch (IOException e) { throw new ClickHouseException(e.getMessage(), e); -
client-v2/src/main/java/com/clickhouse/client/api/DataTypeUtils.java (53-53)
There's an extra space between 'final' and 'SimpleDateFormat' in the declaration of OLD_TIME_WITH_NANOS_FORMATTER.
public static final SimpleDateFormat OLD_TIME_WITH_NANOS_FORMATTER = new SimpleDateFormat("HH:mm:ss.SSSSSSSSS");
💡 To request another review, post a new comment with "/windsurf-review".
Comment on lines
47
to
53
| public static final SimpleDateFormat OLD_DATE_TIME_FORMATTER = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); | ||
|
|
||
| public static final SimpleDateFormat OLD_DATE_FORMATTER = new SimpleDateFormat("yyyy-MM-dd"); | ||
|
|
||
| public static final SimpleDateFormat OLD_TIME_FORMATTER = new SimpleDateFormat("HH:mm:ss"); | ||
|
|
||
| public static final SimpleDateFormat OLD_TIME_WITH_NANOS_FORMATTER = new SimpleDateFormat("HH:mm:ss.SSSSSSSSS"); |
Contributor
There was a problem hiding this comment.
The newly added SimpleDateFormat instances (OLD_DATE_TIME_FORMATTER, OLD_DATE_FORMATTER, OLD_TIME_FORMATTER, OLD_TIME_WITH_NANOS_FORMATTER) are not thread-safe. Consider using DateTimeFormatter instead, which is thread-safe, or ensure these formatters are used in a thread-safe manner.
Comment on lines
78
to
79
| } else if (bytesOrString instanceof byte[]) { | ||
| sb.append(bytesOrString); |
Contributor
There was a problem hiding this comment.
The byte array handling in stringToString() is incorrect. When appending a byte[] to StringBuilder with sb.append(bytesOrString), it will use the default toString() of byte[] which returns the object identity (like '[B@1a2b3c4d') rather than the actual content. Consider using new String((byte[])bytesOrString) or another appropriate conversion method.
client-v2/src/main/java/com/clickhouse/client/api/internal/BaseCollectionConverter.java
Show resolved
Hide resolved
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/added firstCloses #2575
Checklist
Delete items not relevant to your PR: