[jdbc-v2] Parser issues fix #2506
Merged
+154
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several parser grammar issues in the JDBC v2 driver to properly handle CTE (Common Table Expression) with unbound columns, IN expressions with parameters, and keyword aliases for time units.
- Adds support for CTE with unbound columns that can reference parameters
- Fixes parsing of IN expressions with parameter placeholders like "SELECT * FROM t WHERE v in (?)"
- Enables time unit keywords (YEAR, DAY, MONTH, HOUR, MINUTE, SECOND) to be used as aliases
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ClickHouseParser.g4 | Updates grammar to support CTE unbound columns, UNION DISTINCT, and time unit keyword aliases |
| ParsedPreparedStatement.java | Adds handler for CTE unbound column parameters |
| SqlParserTest.java | Adds comprehensive test cases for new grammar features |
| PreparedStatementTest.java | Adds integration tests for CTE and IN clause functionality |
jdbc-v2/src/main/antlr4/com/clickhouse/jdbc/internal/ClickHouseParser.g4
Outdated
Show resolved
Hide resolved
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does fixes in parser grammar to handle:
Closes #2500
Closes #2493
Closes #2478
Closes #2504
Checklist
Delete items not relevant to your PR: