[client-v2] Fix the build #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR updates HttpAPIClientHelper to be compatible with JDK 8 by removing reliance on String.isBlank() and adjusting the URLEncoder.encode invocation.
- Replace
String.isBlank()with a null-safetrim().isEmpty()check - Use the JDK 8
URLEncoder.encode(String, String)overload and add exception handling - Import
UnsupportedEncodingExceptionand wrap encoding failures inClientException
Comments suppressed due to low confidence (1)
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java:778
- [nitpick] The exception message is a bit unclear; consider rewording to "Failed to encode header value to UTF-8" for greater accuracy and consistency.
throw new ClientException("Failed to convert string to UTF8" , e);
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Show resolved
Hide resolved
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrote to use JDK 8 API (String.isBlank() is useless because it requires null check)
Checklist
Delete items not relevant to your PR: