Skip to content

Conversation

@chernser
Copy link
Contributor

@chernser chernser commented Jun 5, 2025

Summary

There are two group of tests in the repo: unit and integration. However some tests are missing the group definition in the @Test annotation. This causes these tests skipped. This PR fixes the problem:

  • unit tests are all that have unit or no group
  • integration tests are all that have integration group
  • most test suite classes are marked as integration so all tests inside them will be executed at integration test stage despite specified group

Closes #2430

Checklist

Delete items not relevant to your PR:

Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file skipped due to size limits:
  • client-v2/src/test/java/com/clickhouse/client/query/QueryTests.java

💡 To request another review, post a new comment with "/windsurf-review".

@chernser chernser merged commit 5860516 into main Jun 5, 2025
20 of 23 checks passed
@chernser chernser deleted the fix_tests_running branch June 5, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lots of unit tests don't seem to be executed in mvn test/mvn verify

2 participants