[client-v2] Move default values to Enum #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng them in builder constructor
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes client default settings into the ClientConfigProperties enum and removes the deprecated useNewImplementation flag from the builder.
- Moved all default values into
ClientConfigPropertiesand initialize them in theBuilderconstructor - Removed
useNewImplementation(...)and its related logic - Updated tests to drop
useNewImplementationcalls
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| client-v2/src/main/java/com/clickhouse/client/api/ClientConfigProperties.java | Added defaultValue for enum entries, removed mutable defaults |
| client-v2/src/main/java/com/clickhouse/client/api/Client.java | Removed useNewImplementation parameter and default-setting code |
| client-v2/src/test/java/com/clickhouse/client/QueryTests.java | Dropped .useNewImplementation(...) call |
| client-v2/src/test/java/com/clickhouse/client/metadata/MetadataTests.java | Dropped .useNewImplementation(...) call |
| client-v2/src/test/java/com/clickhouse/client/command/CommandTests.java | Dropped .useNewImplementation(...) call |
| client-v2/src/test/java/com/clickhouse/client/ProxyTests.java | Dropped .useNewImplementation(...) call |
| client-v2/src/test/java/com/clickhouse/client/HttpTransportTests.java | Dropped .useNewImplementation(...) calls |
| client-v2/src/test/java/com/clickhouse/client/ClientTests.java | Added new coverage for defaults and removed useNewImplementation |
Contributor
Author
|
@mzitnik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Client.Builder#useNewImplementation()Closes #2269
Checklist
Delete items not relevant to your PR: