[client-v2] fixed NPE and added test #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
approved these changes
May 9, 2025
| initTable(tableName, createSQL); | ||
|
|
||
| InsertSettings localSettings = new InsertSettings(settings.getAllSettings()); | ||
| localSettings.setOption(ClientConfigProperties.ASYNC_OPERATIONS.getKey(), true); |
Contributor
There was a problem hiding this comment.
Can we also have a test with async disabled
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Null Pointer Exception by ensuring that a default JVM pool is used when no executor is provided, and it adds integration tests for async insert operations.
- Adds a new async insert test verifying the async operation behavior.
- Modifies the async operation method in the client to handle cases where the shared executor is null.
- Comments out legacy logging configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client-v2/src/test/java/com/clickhouse/client/insert/InsertTests.java | Introduces a new async data insertion test and updates logging code. |
| client-v2/src/main/java/com/clickhouse/client/api/Client.java | Refines asynchronous operation handling by checking for a null executor. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2355 by using default JVM pool in case executor is no specified by client nor client is configured for async operations
Checklist
Delete items not relevant to your PR: