Solves issue-2191 #2337
Merged
Solves issue-2191 #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chernser
reviewed
Apr 24, 2025
| this.configuration.put(ClientConfigProperties.SERVER_TIMEZONE.getKey(), reader.getString("timezone")); | ||
| serverVersion = reader.getString("version"); | ||
| // only if 2 properties are set disable retrieval from server | ||
| if (!this.configuration.containsKey(ClientConfigProperties.SERVER_TIMEZONE.getKey()) && !this.configuration.containsKey(ClientConfigProperties.SERVER_VERSION.getKey())) { |
Contributor
There was a problem hiding this comment.
I think. in the future it will be a bug when more then timezone is get with server info.
So I'd just have an explicit flag documenting that all required configuration should be set. In the builder test that all required configuration is set
chernser
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the client wants to disable the retrieval of the server version & server timezone (extra query when init of JDBC Connection)
Example (how to disable)
Closes #2191
Checklist
Delete items not relevant to your PR: