Solve 2327 - Does not escape correctly UUID #2331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #2327 by fixing how UUID values are escaped before being inserted into a ClickHouse table. Key changes include adding a new test case that validates the UUID insertion and updating the encodeObject method in PreparedStatementImpl.java to handle UUIDs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| jdbc-v2/src/test/java/com/clickhouse/jdbc/PreparedStatementTest.java | Added a test case for inserting a UUID into a table |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/PreparedStatementImpl.java | Updated the encodeObject method to correctly escape UUID values |
Comments suppressed due to low confidence (2)
jdbc-v2/src/test/java/com/clickhouse/jdbc/PreparedStatementTest.java:586
- [nitpick] The test method name 'testWriteCollection' may be misleading as it primarily tests UUID insertion. Consider renaming it to something like 'testInsertUUID' for clarity.
void testWriteCollection() throws Exception {
jdbc-v2/src/main/java/com/clickhouse/jdbc/PreparedStatementImpl.java:657
- Verify that returning the UUID as a quoted and escaped string is the intended behavior for ClickHouse's UUID type. If ClickHouse expects UUIDs in a different format (e.g. unquoted), adjust the escaping accordingly.
return "'" + escapeString(((UUID) x).toString()) + "'";
chernser
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solve 2327 - Does not escape correctly UUID
Closes #2327
Checklist
Delete items not relevant to your PR: