Adjust getIndexInfo to return an empty ResultSet instead of a null value #2315
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates DatabaseMetaData.getIndexInfo to return an empty ResultSet instead of null, ensuring that JDBC calls do not unexpectedly receive a null value. It also renames the DatabaseMetaData class to DatabaseMetaDataImpl and updates its references, and adds a new integration test for the getIndexInfo behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataTest.java | Updated test to reference DatabaseMetaDataImpl and assert an empty ResultSet for getIndexInfo |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java | Renamed class from DatabaseMetaData and modified getIndexInfo to return an empty ResultSet using a SQL query |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/ConnectionImpl.java | Updated to import and reference DatabaseMetaDataImpl instead of the previous class |
|
| public ResultSet getIndexInfo(String catalog, String schema, String table, boolean unique, boolean approximate) throws SQLException { | ||
| return null; | ||
| try { | ||
| String sql = "SELECT null AS TABLE_CAT, null AS TABLE_SCHEM, null AS TABLE_NAME, null AS NON_UNIQUE," + |
There was a problem hiding this comment.
I would expect that we use https://clickhouse.com/docs/sql-reference/statements/show#show-index to get information about indexes.
Summary
Closes #2286
Checklist
Delete items not relevant to your PR: