Skip to content

Added some null pointer checks for edge cases #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Paultagoras merged 1 commit into from
Apr 17, 2025
Merged

Added some null pointer checks for edge cases #2314

Paultagoras merged 1 commit into from
Apr 17, 2025

Conversation

@Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Apr 17, 2025

Summary

Added null checks to prevent NPE when using queryAll with INSERT INTO SELECT statements

Closes #2150

Checklist

Delete items not relevant to your PR:

@Paultagoras Paultagoras self-assigned this Apr 17, 2025
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 17, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
63.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Paultagoras Paultagoras merged commit 5a96f47 into main Apr 17, 2025
24 of 25 checks passed
@Paultagoras Paultagoras deleted the query-all-npe branch April 17, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chernser chernser chernser approved these changes

@mzitnik mzitnik Awaiting requested review from mzitnik

Assignees

@Paultagoras Paultagoras

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[client-v2] QueryAll causes NPE when no response (INSERT)

3 participants

@Paultagoras @chernser